netdev - Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190107.082938.1649593594398135118.davem@davemloft.net>
Date:   Mon, 07 Jan 2019 08:29:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     esyr@...hat.com
Cc:     mlichvar@...hat.com, netdev@...r.kernel.org,
        richardcochran@...il.com, jacob.e.keller@...el.com,
        mtosatti@...hat.com
Subject: Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct
 ptp_sys_offset_extended

From: Eugene Syromiatnikov <esyr@...hat.com>
Date: Mon, 7 Jan 2019 16:22:29 +0100

> Otherwise it is impossible to use it for something else, as it will break
> userspace that puts garbage there.
> 
> The same check should be done in other structures, but the fact that
> data in reserved fields is ignored is already part of the kernel ABI.
> 
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>

I think the opportunity to enforce this has passed and you will break
userspace by doing this.