netdev - Re: [PATCH net 2/2] ptp: uapi: change _IOW to IOWR in PTP_SYS_OFFSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190107.082958.2244476771234919771.davem@davemloft.net>
Date:   Mon, 07 Jan 2019 08:29:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     esyr@...hat.com
Cc:     mlichvar@...hat.com, netdev@...r.kernel.org,
        richardcochran@...il.com, jacob.e.keller@...el.com,
        mtosatti@...hat.com
Subject: Re: [PATCH net 2/2] ptp: uapi: change _IOW to IOWR in
 PTP_SYS_OFFSET_EXTENDED definition

From: Eugene Syromiatnikov <esyr@...hat.com>
Date: Mon, 7 Jan 2019 16:22:38 +0100

> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -147,7 +147,7 @@ struct ptp_pin_desc {
>  #define PTP_SYS_OFFSET_PRECISE \
>  	_IOWR(PTP_CLK_MAGIC, 8, struct ptp_sys_offset_precise)
>  #define PTP_SYS_OFFSET_EXTENDED \
> -	_IOW(PTP_CLK_MAGIC, 9, struct ptp_sys_offset_extended)
> +	_IOWR(PTP_CLK_MAGIC, 9, struct ptp_sys_offset_extended)

Again, this changes the ioctl cmd value and will break userspace.