netdev - Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190107165741.GD27782@localhost>
Date:   Mon, 7 Jan 2019 17:57:41 +0100
From:   Miroslav Lichvar <mlichvar@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     esyr@...hat.com, netdev@...r.kernel.org, richardcochran@...il.com,
        jacob.e.keller@...el.com, mtosatti@...hat.com
Subject: Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct
 ptp_sys_offset_extended

On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote:
> From: Eugene Syromiatnikov <esyr@...hat.com>
> Date: Mon, 7 Jan 2019 16:22:29 +0100
> 
> > Otherwise it is impossible to use it for something else, as it will break
> > userspace that puts garbage there.
> > 
> > The same check should be done in other structures, but the fact that
> > data in reserved fields is ignored is already part of the kernel ABI.
> > 
> > Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>
> 
> I think the opportunity to enforce this has passed and you will break
> userspace by doing this.

FWIW, this ioctl wasn't present in a stable Linux release yet and the
two applications that I know that support it both zero the rsv field,
so I think at least this patch is very unlikely to break anything.

Anyway, thanks to Eugene for catching the issues.

-- 
Miroslav Lichvar