netdev - Re: [PATCH] packet: Do not leak dev refcounts on error exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-LfFfJHgkNESkNZ-RgXLQ6=Ag9TsOCppnvCyWT6oeMmcQ@mail.gmail.com>
Date:   Tue, 8 Jan 2019 18:48:08 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Jason Gunthorpe <jgg@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: Re: [PATCH] packet: Do not leak dev refcounts on error exit

On Tue, Jan 8, 2019 at 6:41 PM Jason Gunthorpe <jgg@...lanox.com> wrote:
>
> 'dev' is non NULL when the addr_len check triggers so it must goto a label
> that does the dev_put otherwise dev will have a leaked refcount.
>
> This bug causes the ib_ipoib module to become unloadable when using
> systemd-network as it triggers this check on InfiniBand links.
>
> Fixes: 99137b7888f4 ("packet: validate address length")
> Reported-by: Leon Romanovsky <leonro@...lanox.com>
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Argh, indeed. Thanks for the fix.