netdev - Re: [PATCH] packet: Do not leak dev refcounts on error exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190108.185930.1694064159905466574.davem@davemloft.net>
Date:   Tue, 08 Jan 2019 18:59:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jgg@...lanox.com
Cc:     linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        willemb@...gle.com, leonro@...lanox.com
Subject: Re: [PATCH] packet: Do not leak dev refcounts on error exit

From: Jason Gunthorpe <jgg@...lanox.com>
Date: Tue, 8 Jan 2019 23:27:06 +0000

> 'dev' is non NULL when the addr_len check triggers so it must goto a label
> that does the dev_put otherwise dev will have a leaked refcount.
> 
> This bug causes the ib_ipoib module to become unloadable when using
> systemd-network as it triggers this check on InfiniBand links.
> 
> Fixes: 99137b7888f4 ("packet: validate address length")
> Reported-by: Leon Romanovsky <leonro@...lanox.com>
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>

Applied and queued up for -stable, thanks.