netdev - Re: [RFC net-next 00/14] net: dsa: management mode for bcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190115.132949.1070071604329374251.davem@davemloft.net>
Date:   Tue, 15 Jan 2019 13:29:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        idosch@...lanox.com, jiri@...lanox.com,
        ilias.apalodimas@...aro.org, ivan.khoronzhuk@...aro.org,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com
Subject: Re: [RFC net-next 00/14] net: dsa: management mode for bcm_sf2

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue, 15 Jan 2019 11:41:16 -0800

> This patch series does a number of things in order to enable
> management mode for bcm_sf2 (which could be easily extended to b53 with
> proper testing later on). In order to get there, there were several use
> cases that did not seem to be working correctly, such as:
> 
> - VLAN devices on top of switch ports not being member of a bridge, with
>   other switch ports being bridged, with the bridge having VLAN
>   filtering enabled.
> 
> - lack of multicast filtering by default on network ports which should
>   be happening in order for the non-bridged DSA ports to behave strictly
>   as Ethernet NICs with proper filering
> 
> - improper or even lack of MDB programming requests for network ports
>   that are not part of a bridge, or when the bridge has multicast
>   snooping turned off
> 
> Hopefully the changes to net/8021q and net/bridge are deemed acceptable.
> 
> Here are some of the uses cases that were tested after this patch series
> (all commands are running on the device being tested) and
> iperf/ping/etc. should be working for/after all steps:
 ...

At a high level these changes look good to me.