netdev - Re: [PATCH net-next] net: phy: don't include asm/irq.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190115212951.GB26788@lunn.ch>
Date:   Tue, 15 Jan 2019 22:29:51 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: don't include asm/irq.h directly

> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 189cd2048..f95753eda 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -36,8 +36,6 @@
>  #include <linux/uaccess.h>
>  #include <linux/atomic.h>
>  
> -#include <asm/irq.h>
> -

Hi Heiner

There is a call to request_threaded_irq() and free_irq() in this
file. So it should probably include linux/irq.h.

      Andrew