netdev - Re: [PATCH net-next] net: phy: don't include asm/irq.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23f72b6f-07e8-45e3-074d-eb82df525956@gmail.com>
Date:   Tue, 15 Jan 2019 22:33:06 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: don't include asm/irq.h directly

On 15.01.2019 22:29, Andrew Lunn wrote:
>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
>> index 189cd2048..f95753eda 100644
>> --- a/drivers/net/phy/phy.c
>> +++ b/drivers/net/phy/phy.c
>> @@ -36,8 +36,6 @@
>>  #include <linux/uaccess.h>
>>  #include <linux/atomic.h>
>>  
>> -#include <asm/irq.h>
>> -
> 
> Hi Heiner
> 
> There is a call to request_threaded_irq() and free_irq() in this
> file. So it should probably include linux/irq.h.
> 
Both functions are declared in linux/interrupt.h which is included.
If you look into linux/irq.h a comment at the very beginning states
that this file shouldn't be included by generic code.

>       Andrew
> 
Heiner