netdev - Re: Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Jan 2019 10:15:48 +0200
From:   Samu Nuutamo <samu.nuutamo@...cit.fi>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge

On Mon, Jan 14, 2019 at 10:03:57AM -0800, Florian Fainelli wrote:
> Samu, is this fixed link using a GPIO to determine the link state? Does
> this patch help at all?
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c
> index 8a517d8fb9d1..9dedb9b22c13 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -721,7 +721,7 @@ static void mv88e6xxx_mac_config(struct dsa_switch
> *ds, int port,
>                 return;
> 
>         if (mode == MLO_AN_FIXED) {
> -               link = LINK_FORCED_UP;
> +               link = state->link;
>                 speed = state->speed;
>                 duplex = state->duplex;
>         } else if (!mv88e6xxx_phy_is_internal(ds, port)) {

Hi Florian,

I'm not 100% sure but it looks like GPIO is not used for that purpose.
I tested your patch but unfortunately it didn't work as the link keeps
cycling down/up.

- Samu