netdev - Re: [RFC net-next 0/6] devlink: add device (driver) information API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190115081244.GA2290@nanopsycho>
Date:   Tue, 15 Jan 2019 09:12:44 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [RFC net-next 0/6] devlink: add device (driver) information API

Tue, Jan 15, 2019 at 02:57:55AM CET, andrew@...n.ch wrote:
>> I think the plan was to use this opportunity to move the information
>> which belongs in devlink to devlink.  There is absolutely nothing
>> netdev specific here, and ethtool uses a netdev as a handle.  We can
>> have the new ethtool command just issue a devlink request behind the
>> scenes if we care.
>
>Hi Jakub
>
>Using that argument, you should probably make the devlink core call
>the ethtool .get_drvinfo op if the device does not implement the
>devlink op.

I imagine it happening the other way around. Updated drivers would
implement only the devlink interface. A compat layer would be introduced
to redirect from ethtool calls into devlink to gather information (like
fw version and other stuff which is currently in ethtool).

This approach would provide a single and complete interface between
driver and kernel and it would also maintain exinsting ethtool
interface.

>
>    Andrew