netdev - Re: [RFC iproute2-next] devlink: add info subcommand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190115082011.GB2290@nanopsycho>
Date:   Tue, 15 Jan 2019 09:20:11 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [RFC iproute2-next] devlink: add info subcommand

[...]

> static void help(void)
> {
> 	pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n"
> 	       "       devlink [ -f[orce] ] -b[atch] filename\n"
>-	       "where  OBJECT := { dev | port | sb | monitor | dpipe | resource | region }\n"
>+	       "where  OBJECT := { dev | port | sb | monitor | dpipe | resource | region | info }\n"

I think that "info" should be nested under "dev". It is related to dev.
Maybe it even does not have to be a separate command and can be a nested
attribute to existing DEVLINK_CMD_GET cmd.



> 	       "       OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] | -v[erbose] }\n");
> }