netdev - Re: [Patch net] net_sched: refetch skb protocol for each filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d1b21a5-e2fe-572b-be99-2c74409a7290@mojatatu.com>
Date:   Tue, 15 Jan 2019 10:14:27 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Martin Olsson <martin.olsson+netdev@...torsecurity.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Lucas Bates <lucasb@...atatu.com>
Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter

On 2019-01-13 3:58 p.m., Cong Wang wrote:
> On Sat, Jan 12, 2019 at 4:23 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>> Cong,
>> I am a little worried about the impact of this change. Smells
>> more like it has to do with Vlan action or related issues
>> than with reclassifying.
> 
> You can verify this patch with Martin's test case. I verified it
> with the script below, it works as expected.
> 

Your script is slightly different from his. Probably doesnt matter
in the bigger picture - but lets give Lucas a chance to test.
So a ping from test1->test2 should be sufficient here, yes?

cheers,
jamal