netdev - Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e90a8dc3-1af1-0fb1-e487-ba5813e3a8d7@mojatatu.com>
Date:   Tue, 15 Jan 2019 10:16:57 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        Bartek Kois <bartek.kois@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: Problem with queuing vlan tagged packets after migration from
 3.16.0 to 4.9.0

On 2019-01-14 3:12 a.m., Simon Horman wrote:
> On Sat, Jan 12, 2019 at 07:12:34AM -0500, Jamal Hadi Salim wrote:
>> On 2019-01-10 8:45 a.m., Simon Horman wrote:
>>> On Sun, Jan 06, 2019 at 09:44:30AM -0500, Jamal Hadi Salim wrote:
>>

>>
>> As opposed to what used to work before which would
>> have matched at packet offset.
> 
> So the old feature is permanently broken?

Yes.

> 
>> If there is agreement (lots of bikeshedding last time)
>> i or someone else can whip a patch for this.
> 
> Backwards compatibility aside I have no objection.

Backwards compatibility should go back as far as
when it was broken. It wont work prio to that because
there was no vlan metadata on the skb.

cheers,
jamal