netdev - Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWOT8+33AYR1RgufswcbikvLsC=3MgmVvydp5SPu-61-g@mail.gmail.com>
Date:   Tue, 15 Jan 2019 10:19:51 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Simon Horman <simon.horman@...ronome.com>,
        Bartek Kois <bartek.kois@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: Problem with queuing vlan tagged packets after migration from
 3.16.0 to 4.9.0

On Tue, Jan 15, 2019 at 7:09 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> On 2019-01-13 1:22 p.m., Cong Wang wrote:
> > On Sat, Jan 12, 2019 at 4:12 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
> >>
> >> It will be a new feature in the sense the user will have to specify
> >> something like (adding "mark" for clarify):
> >>
> >> tc filter add .... protocol 802.1q .. u32 \
> >> match u32 0 0 \
> >> mark 15 \
> >> vlanid 1234
> >> action vlan pop reclassify
> >
> > This is clearly a new feature, however, it only solves one part of
> > the problem, the length of IPv4 header is still various and there
> > is no way to predict it.
>
>
> As i mentioned in my earlier email, that feature should work.
> What is broken?

I never say it is broken. I am saying you only fix vlan case by
introducing "vlanid XXX" and leave IPv4 option cases unfixed.
As I keep saying, this is a kinda design flaw of u32 probably
can't be workarounded.

Thanks.