netdev - Re: [RFC PATCH 2/3] riscv: add build infra for JIT compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNiP=cBhHurxxcpbUyt9BZyV1uHaLfHD-89N-rAkAbjr-g@mail.gmail.com>
Date:   Tue, 15 Jan 2019 17:09:53 +0100
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-riscv@...ts.infradead.org,
        Palmer Dabbelt <palmer@...ive.com>, davidlee@...ive.com,
        Daniel Borkmann <daniel@...earbox.net>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH 2/3] riscv: add build infra for JIT compiler

Den tis 15 jan. 2019 kl 16:43 skrev Christoph Hellwig <hch@...radead.org>:
>
> >  core-y += arch/riscv/kernel/ arch/riscv/mm/
> >
> > +ifeq ($(CONFIG_ARCH_RV64I),y)
> > +core-y += arch/riscv/net/
> > +endif
>
> I think this should be core-$(CONFIG_ARCH_RV64I) to get the same result.
> Or even better just core-y given that the Kconfig dependencies should
> ensure you can't ever enable CONFIG_BPF_JIT for 32-bit builds.
>

Good point! I'll address that!

> > new file mode 100644
> > index 000000000000..b0b6ac13edf5
> > --- /dev/null
> > +++ b/arch/riscv/net/Makefile
> > @@ -0,0 +1,5 @@
> > +#
> > +# RISCV networking code
> > +#
>
> I don't think this comment adds any value.  In fact it is highly
> confusing given that we use bpf for a lot more than networking these
> days.
>

Yeah, I agree. I'll remove that.

> > diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net/bpf_jit_comp.c
> > new file mode 100644
> > index 000000000000..7e359d3249ee
> > --- /dev/null
> > +++ b/arch/riscv/net/bpf_jit_comp.c
> > @@ -0,0 +1,4 @@
> > +struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
> > +{
> > +     return prog;
> > +}
>
> Please don't just add stubs files.  This patch should probably be merged
> into the one adding the actual implementation.

Noted! I'll remove that!

Thanks for taking a look, Christoph!


Björn