lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jan 2019 15:48:29 +0100 From: Andrew Lunn <andrew@...n.ch> To: Thomas Petazzoni <thomas.petazzoni@...tlin.com> Cc: Florian Fainelli <f.fainelli@...il.com>, "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Paul Kocialkowski <paul.kocialkowski@...tlin.com> Subject: Re: [PATCH] net: phy: mdio_bus: add missing device_del() in mdiobus_register() error handling > The actual error that we had from devm_gpiod_get_optional() was > -EPROBE_DEFER, due to the GPIO being provided by a driver that is > probed later than the Ethernet controller driver. > > To fix this, we simply add the missing device_del() invocation in the > error path. Hi Thomas Reviewed-by: Andrew Lunn <andrew@...n.ch> However, i wounder if it makes sense to add a label before the existing device_del() at the end of the function, and convert this, and the case above into a goto? That might scale better, avoiding the same issue in the future? Thanks Andrew
Powered by blists - more mailing lists