netdev - Re: [PATCH bpf-next] bpf: bpf_setsockopt: reset sock dst on SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afdcfed4-f38b-4bbf-9d7a-2c3b741fb02e@iogearbox.net>
Date:   Thu, 17 Jan 2019 16:50:01 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Peter Oskolkov <posk@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>, netdev@...r.kernel.org
Cc:     Peter Oskolkov <posk.devel@...il.com>,
        Maciej Żenczykowski <maze@...gle.com>
Subject: Re: [PATCH bpf-next] bpf: bpf_setsockopt: reset sock dst on SO_MARK
 changes

On 01/16/2019 05:47 PM, Peter Oskolkov wrote:
> In sock_setsockopt() (net/core/sock.h), when SO_MARK option is used
> to change sk_mark, sk_dst_reset(sk) is called. The same should be done
> in bpf_setsockopt.
> 
> Reported-by: Maciej Żenczykowski <maze@...gle.com>
> Signed-off-by: Peter Oskolkov <posk@...gle.com>

Given this is a fix, I'm inclined to apply to bpf tree. Objections?

Thanks,
Daniel