lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 17 Jan 2019 08:36:00 -0800
From:   Peter Oskolkov <posk@...gle.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Peter Oskolkov <posk.devel@...il.com>,
        Maciej ┼╗enczykowski <maze@...gle.com>
Subject: Re: [PATCH bpf-next] bpf: bpf_setsockopt: reset sock dst on SO_MARK changes

On Thu, Jan 17, 2019 at 7:50 AM Daniel Borkmann <daniel@...earbox.net> wrote:
>
> On 01/16/2019 05:47 PM, Peter Oskolkov wrote:
> > In sock_setsockopt() (net/core/sock.h), when SO_MARK option is used
> > to change sk_mark, sk_dst_reset(sk) is called. The same should be done
> > in bpf_setsockopt.
> >
> > Reported-by: Maciej ┼╗enczykowski <maze@...gle.com>
> > Signed-off-by: Peter Oskolkov <posk@...gle.com>
>
> Given this is a fix, I'm inclined to apply to bpf tree. Objections?

Up to the maintainer... :)

>
> Thanks,
> Daniel

Powered by blists - more mailing lists