netdev - Re: [PATCH bpf-next 1/5] bpf: add BPF_CGROUP_INET{4,6}_SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Jan 2019 15:23:03 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        ast@...nel.org, daniel@...earbox.net,
        Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH bpf-next 1/5] bpf: add BPF_CGROUP_INET{4,6}_SOCK_RELEASE
 hooks

Hi Stanislav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-add-BPF_CGROUP_INET-4-6-_SOCK_RELEASE-hooks/20190118-141334
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-randconfig-a2-201902 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/ipv6/af_inet6.c: In function 'inet6_release':
>> net/ipv6/af_inet6.c:468:3: error: implicit declaration of function 'BPF_CGROUP_RUN_PROG_INET6_SOCK_RELEASE' [-Werror=implicit-function-declaration]
      BPF_CGROUP_RUN_PROG_INET6_SOCK_RELEASE(sock->sk);
      ^
   cc1: some warnings being treated as errors

vim +/BPF_CGROUP_RUN_PROG_INET6_SOCK_RELEASE +468 net/ipv6/af_inet6.c

   459	
   460	int inet6_release(struct socket *sock)
   461	{
   462		struct sock *sk = sock->sk;
   463	
   464		if (!sk)
   465			return -EINVAL;
   466	
   467		if (!sk->sk_kern_sock)
 > 468			BPF_CGROUP_RUN_PROG_INET6_SOCK_RELEASE(sock->sk);
   469	
   470		/* Free mc lists */
   471		ipv6_sock_mc_close(sk);
   472	
   473		/* Free ac lists */
   474		ipv6_sock_ac_close(sk);
   475	
   476		return __inet_release(sock);
   477	}
   478	EXPORT_SYMBOL(inet6_release);
   479	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32601 bytes)