netdev - RE: [PATCH] net: dpaa2: build ptp clock driver in default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Jan 2019 07:18:32 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
Subject: RE: [PATCH] net: dpaa2: build ptp clock driver in default

Hi Richard,

> -----Original Message-----
> From: Richard Cochran <richardcochran@...il.com>
> Sent: Friday, January 18, 2019 9:26 AM
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: netdev@...r.kernel.org; David S . Miller <davem@...emloft.net>; Ioana
> Ciocoi Radulescu <ruxandra.radulescu@....com>
> Subject: Re: [PATCH] net: dpaa2: build ptp clock driver in default
> 
> On Mon, Jan 14, 2019 at 05:44:23PM +0800, Yangbo Lu wrote:
> > This patch is to set "default y" for dpaa2 ptp driver building.
> > It will provide user an available ptp clock in default.
> >
> > Signed-off-by: Yangbo Lu <yangbo.lu@....com>
> > ---
> >  drivers/net/ethernet/freescale/dpaa2/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig
> b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > index 809a155..15351fc 100644
> > --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > @@ -11,6 +11,7 @@ config FSL_DPAA2_PTP_CLOCK
> >  	tristate "Freescale DPAA2 PTP Clock"
> >  	depends on FSL_DPAA2_ETH && POSIX_TIMERS
> >  	select PTP_1588_CLOCK
> 
> We want to use "imply" instead of "select" here.

[Y.b. Lu] Just learned the "imply" from the doc. I have a query here.
Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work.
Doesn't it matter?

Thanks.

> 
> > +	default y
> 
> I'm okay with the defaulting to yes.
> 
> Thanks,
> Richard