netdev - Re: [PATCH] net: dpaa2: build ptp clock driver in default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190118201444.d44uenasdgywhsyg@localhost>
Date:   Fri, 18 Jan 2019 12:14:44 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     "Y.b. Lu" <yangbo.lu@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
Subject: Re: [PATCH] net: dpaa2: build ptp clock driver in default

On Fri, Jan 18, 2019 at 07:18:32AM +0000, Y.b. Lu wrote:
> > We want to use "imply" instead of "select" here.
> 
> [Y.b. Lu] Just learned the "imply" from the doc. I have a query here.
> Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work.
> Doesn't it matter?

If PTP_1588_CLOCK is not compiled, then your driver should handle this
case:

 * ptp_clock_register() - register a PTP hardware clock driver

 * Returns a valid pointer on success or PTR_ERR on failure.  If PHC
 * support is missing at the configuration level, this function
 * returns NULL, and drivers are expected to gracefully handle that
 * case separately.


Thanks,
Richard