[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190118090945.GI25424@kwain>
Date: Fri, 18 Jan 2019 10:09:45 +0100
From: Antoine Tenart <antoine.tenart@...tlin.com>
To: Richard Cochran <richardcochran@...il.com>
Cc: Antoine Tenart <antoine.tenart@...tlin.com>, davem@...emloft.net,
alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com,
ralf@...ux-mips.org, paul.burton@...s.com, jhogan@...nel.org,
netdev@...r.kernel.org, linux-mips@...r.kernel.org,
thomas.petazzoni@...tlin.com, quentin.schulz@...tlin.com,
allan.nielsen@...rochip.com
Subject: Re: [PATCH net-next 0/8] net: mscc: PTP offloading support
Hi Richard,
On Thu, Jan 17, 2019 at 06:13:42PM -0800, Richard Cochran wrote:
> On Thu, Jan 17, 2019 at 11:02:04AM +0100, Antoine Tenart wrote:
> > This series adds support for the PTP offloading support in the Mscc
> > Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are
> > supported.
> >
> > In order to make use of the PTP offloading support, two new register
> > banks were described in the Ocelot device tree. The use of those
> > registers by the Mscc Ocelot Ethernet switch driver is made optional for
> > dt compatibility reasons. For the same reason a new interrupt is
> > described, and its use is also made optinal for compatibility reasons.
> > All of this is done ine patches 1-5.
> >
> > The PTP offloading support itself is added in patch 8.
>
> The subject lines and this description are misleading. You are not
> offloading the Precision Time Protocol. Instead, this series
> implements a normal PHC driver.
>
> Please change the text to avoid the phrase, "PTP offloading".
Will do.
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists