netdev - Re: [PATCH net-next 06/13] net: namespace: perform strict checks also for doit handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190118100010.24150d0f@cakuba.netronome.com>
Date:   Fri, 18 Jan 2019 10:00:10 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     davem@...emloft.net, dsahern@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, ktkhai@...tuozzo.com
Subject: Re: [PATCH net-next 06/13] net: namespace: perform strict checks
 also for doit handlers

On Fri, 18 Jan 2019 09:17:46 +0100, Nicolas Dichtel wrote:
> > +static int rtnl_net_valid_getid_req(struct sk_buff *skb,
> > +				    const struct nlmsghdr *nlh,
> > +				    struct nlattr **tb,
> > +				    struct netlink_ext_ack *extack)
> > +{
> > +	int i, err;
> > +
> > +	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(struct rtgenmsg))) {  
> This is not possible, the check is already done in rtnetlink_rcv_msg().

Good point, thanks!