netdev - Re: [PATCH net-next 00/13] net: use strict checks in doit handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190118100118.0fabfa97@cakuba.netronome.com>
Date:   Fri, 18 Jan 2019 10:01:18 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     David Ahern <dsahern@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 00/13] net: use strict checks in doit handlers

On Fri, 18 Jan 2019 07:45:50 -0700, David Ahern wrote:
> On 1/17/19 3:52 PM, Jakub Kicinski wrote:
> > Hi!
> > 
> > This series extends strict argument checking to doit handlers
> > of the GET* nature.  This is a bit tricky since strict checking
> > flag has already been released..
> > 
> > iproute2 did not have a release with strick checks enabled,
> > and it will only need a minor one-liner to pass strick checks
> > after all the work that DaveA has already done.
> > 
> > Big thanks to Dave Ahern for help and guidence.
> > DaveA, does this look good to you?
> > 
> > Jakub Kicinski (13):
> >   net: netlink: add helper to retrieve NETLINK_F_STRICT_CHK
> >   rtnetlink: stats: validate attributes in get as well as dumps
> >   rtnetlink: stats: reject requests for unknown stats
> >   rtnetlink: ifinfo: perform strict checks also for doit handler
> >   net: ipv4: perform strict checks also for doit handlers
> >   net: namespace: perform strict checks also for doit handlers
> >   net: ipv4: ipmr: perform strict checks also for doit handlers
> >   net: ipv6: addr: perform strict checks also for doit handlers
> >   net: ipv6: netconf: perform strict checks also for doit handlers
> >   net: ipv6: addrlabel: perform strict checks also for doit handlers
> >   net: ipv6: route: perform strict checks also for doit handlers
> >   net: mpls: route: perform strict checks also for doit handlers
> >   net: mpls: netconf: perform strict checks also for doit handlers  
> 
> Thanks for working on this. Besides the few nits, all of the changes
> look good to me.

Thanks for those, will fix!

> Looking at RTM_GET handlers I noticed inet_rtm_getroute and
> rtnl_net_getid are not included in this set. Any reason?

I must have misread doit-only as dumpit-only.  Will add.