lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190121182928.GC16212@lunn.ch> Date: Mon, 21 Jan 2019 19:29:28 +0100 From: Andrew Lunn <andrew@...n.ch> To: Heiner Kallweit <hkallweit1@...il.com> Cc: Florian Fainelli <f.fainelli@...il.com>, David Miller <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state > For all invalid states phy_start() basically was a no-op. All it did was > triggering a state machine run, but for all "running" states the poll > loop was active anyway. And if called from PHY_DOWN, the state machine > does nothing. Therefore I see no scenario where jumping to out would > break anything. Hi Heiner It is useful to put this sort of analysis in the commit message. You then won't get people like me asking about it. Andrew
Powered by blists - more mailing lists