lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <51b935de-18d4-fcd5-a858-2bb8ccca484e@gmail.com> Date: Mon, 21 Jan 2019 19:30:53 +0100 From: Heiner Kallweit <hkallweit1@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: Florian Fainelli <f.fainelli@...il.com>, David Miller <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state On 21.01.2019 19:29, Andrew Lunn wrote: >> For all invalid states phy_start() basically was a no-op. All it did was >> triggering a state machine run, but for all "running" states the poll >> loop was active anyway. And if called from PHY_DOWN, the state machine >> does nothing. Therefore I see no scenario where jumping to out would >> break anything. > > Hi Heiner > > It is useful to put this sort of analysis in the commit message. You > then won't get people like me asking about it. > Will add this to my "best practices" list ;) > Andrew > Heiner
Powered by blists - more mailing lists