lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <477939ff-14df-eca7-d652-0164ad6e5f41@gmail.com> Date: Mon, 21 Jan 2019 19:36:56 +0100 From: Heiner Kallweit <hkallweit1@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: Florian Fainelli <f.fainelli@...il.com>, David Miller <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only On 21.01.2019 17:35, Andrew Lunn wrote: > On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: >> The state machine is a no-op before phy_start() has been called. >> Therefore let's enable it in phy_start() only. In phy_start() >> let's call phy_start_machine() instead of phy_trigger_machine(). >> phy_start_machine is an alias for phy_trigger_machine but it makes >> clearer that we start the state machine here instead of just >> triggering a run. > > Hi Heiner > > Documentation/networking/phy.txt has a section "Doing it all yourself" > It would be good to review that, and make sure that documentation is > still valid. I'm not sure any MAC driver actually does do it all > itself. So it might be worth reviewing the whole document and making > updates to remove parts of the text. > Right. I figured out that I have update phy.txt anyway because I recently removed phy_stop_interrupts which is referenced in the documentation. OK if we leave the patch series as is and I submit the documentation update as a separate patch? > Andrew > > Heiner
Powered by blists - more mailing lists