netdev - Re: [PATCH bpf v3] bpftool: fix percpu maps updating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e46b0bd7-b468-624d-69ac-d541ea622599@netronome.com>
Date:   Mon, 21 Jan 2019 11:47:01 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf v3] bpftool: fix percpu maps updating

2019-01-21 12:36 UTC+0100 ~ Paolo Abeni <pabeni@...hat.com>
> When updating a percpu map, bpftool currently copies the provided
> value only into the first per CPU copy of the specified value,
> all others instances are left zeroed.
> 
> This change explicitly copies the user-provided bytes to all the
> per CPU instances, keeping the sub-command syntax unchanged.
> 
> v2 -> v3:
>  - drop unused argument, as per Quentin's suggestion
> v1 -> v2:
>  - rename the helper as per Quentin's suggestion
> 
> Fixes: 71bb428fe2c1 ("tools: bpf: add bpftool")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

All good for me this time, thanks!

Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>