lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190123170816.GH5310@lunn.ch> Date: Wed, 23 Jan 2019 18:08:16 +0100 From: Andrew Lunn <andrew@...n.ch> To: Antoine Tenart <antoine.tenart@...tlin.com> Cc: davem@...emloft.net, sd@...asysnail.net, f.fainelli@...il.com, hkallweit1@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com, quentin.schulz@...tlin.com, allan.nielsen@...rochip.com Subject: Re: [PATCH net-next 05/10] net: phy: introduce a phy_driver macsec helper > +int phy_macsec(struct phy_device *phydev, struct netdev_macsec *macsec) > +{ > + int ret = -EOPNOTSUPP; > + > + if (!phydev->drv) > + return -EIO; > + > + mutex_lock(&phydev->lock); > + > + if (phydev->drv->macsec) > + ret = phydev->drv->macsec(phydev, macsec); > + > + mutex_unlock(&phydev->lock); > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_macsec); > + > @@ -630,6 +634,10 @@ struct phy_driver { > struct ethtool_tunable *tuna, > const void *data); > int (*set_loopback)(struct phy_device *dev, bool enable); > + > +#ifdef CONFIG_MACSEC > + int (*macsec)(struct phy_device *dev, struct netdev_macsec *macsec); > +#endif Hi Antoine So the member only exists if CONFIG_MACSEC is defined. So i think you need similar protection in phy_macsec() or you are going to try to access a member which sometimes does not exist. Andrew
Powered by blists - more mailing lists