lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <955d1bdf-037e-ae26-a9da-8da2a51a7cbd@gmail.com> Date: Wed, 23 Jan 2019 12:11:37 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Antoine Tenart <antoine.tenart@...tlin.com>, davem@...emloft.net, sd@...asysnail.net, andrew@...n.ch, hkallweit1@...il.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com, quentin.schulz@...tlin.com, allan.nielsen@...rochip.com Subject: Re: [PATCH net-next 03/10] net: macsec: move some definitions in a dedicated header On 1/23/19 7:56 AM, Antoine Tenart wrote: > This patch moves some structure, type and identifier definitions into a > MACsec specific header. This patch does not modify how the MACsec code > is running and only move things around. This is a preparation for the > future MACsec hardware offloading support, which will re-use those > definitions outside macsec.c. > > Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com> > --- > drivers/net/macsec.c | 164 +-------------------------------------- > include/net/macsec.h | 178 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 179 insertions(+), 163 deletions(-) > create mode 100644 include/net/macsec.h > > diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c > index 56e354305f76..c3a138dd4386 100644 > --- a/drivers/net/macsec.c > +++ b/drivers/net/macsec.c > @@ -17,10 +17,9 @@ > #include <net/sock.h> > #include <net/gro_cells.h> > > +#include <net/macsec.h> > #include <uapi/linux/if_macsec.h> I would probably go with include/linux/if_macsec.h and have uapi/linux/if_macsec.h include that file directly. This would be consistent with other types of network interfaces: bridge, vlan etc. -- Florian
Powered by blists - more mailing lists