netdev - Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190124105052.3a5bca7a@cakuba.netronome.com>
Date:   Thu, 24 Jan 2019 10:50:52 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     Michal Kubecek <mkubecek@...e.cz>, Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters
 support for devlink_port

On Thu, 24 Jan 2019 15:16:27 +0530, Vasundhara Volam wrote:
> > > > The devlink WoL setting does not have to match the ethtool WoL
> > > > setting.  
> > >
> > > IMHO this is not really a problem. We can either use an additional flag
> > > telling kernel/driver if we are setting runtime or persistent WoL mask
> > > or we can pass (up to) two bitmaps.  
> >
> > I think reusing new netlink ethtool with a special flag would be a nice,
> > complete solution.  We could also address link settings this way (which
> > are a pre-requisite for WoL).
> >
> > I have no strong preference on the mechanism, but for ease of setting
> > as well as dumping would it be workable to use a nesting, like this:
> >
> > Run time settings:
> >   [ETHTOOL_SETTINGS_BLA]
> >     [ETHTOOL_BLA_VAL_1]
> >     [ETHTOOL_BLA_VAL_2]
> >     ...
> >
> > Persistent:
> >   [ETHTOOL_PERSISTENT]
> >     [ETHTOOL_SETTINGS_BLA]
> >       [ETHTOOL_BLA_VAL_1]
> >       [ETHTOOL_BLA_VAL_2]
> >
> > IOW encapsulate settings into a "persistent" attribute?  
> Not sure if current devlink framework allows to encapsulate additional
> settings now.
> But we can think of extending it to support this when there is a requirement.

To be clear the question was to Michal and about ethtool netlink, where
this configuration belongs.