lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Jan 2019 00:07:30 +0100 From: Michal Kubecek <mkubecek@...e.cz> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: netdev@...r.kernel.org, Vasundhara Volam <vasundhara-v.volam@...adcom.com>, davem@...emloft.net, michael.chan@...adcom.com, jiri@...lanox.com Subject: Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port On Tue, Jan 22, 2019 at 02:18:42PM -0800, Jakub Kicinski wrote: > > I think reusing new netlink ethtool with a special flag would be a nice, > complete solution. We could also address link settings this way (which > are a pre-requisite for WoL). > > I have no strong preference on the mechanism, but for ease of setting > as well as dumping would it be workable to use a nesting, like this: > > Run time settings: > [ETHTOOL_SETTINGS_BLA] > [ETHTOOL_BLA_VAL_1] > [ETHTOOL_BLA_VAL_2] > ... > > Persistent: > [ETHTOOL_PERSISTENT] > [ETHTOOL_SETTINGS_BLA] > [ETHTOOL_BLA_VAL_1] > [ETHTOOL_BLA_VAL_2] > > IOW encapsulate settings into a "persistent" attribute? > > How does that look to you, Michal? It's certainly one of the options worth considering. What I like is that this approach would not require knowing (or rather guessing) which attributes are going to allow persistent settings in the future. Michal
Powered by blists - more mailing lists