netdev - Re: [PATCH net-next 0/7] Devlink health updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ba329b5-f550-2c3e-08d7-1094fbe4e6fb@mellanox.com>
Date:   Fri, 25 Jan 2019 09:16:16 +0000
From:   Eran Ben Elisha <eranbe@...lanox.com>
To:     David Miller <davem@...emloft.net>,
        "jiri@...nulli.us" <jiri@...nulli.us>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>
Subject: Re: [PATCH net-next 0/7] Devlink health updates



On 1/25/2019 8:08 AM, David Miller wrote:
> From: Jiri Pirko <jiri@...nulli.us>
> Date: Tue, 22 Jan 2019 17:58:21 +0100
> 
>> Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@...lanox.com wrote:
>>> This patchset fixes some comments that were received for the devlink
>>> health series, mostly around the devlink health buffers API.
>>>
>>> It offers a new devlink<->driver API for passing health dump and diagnose info.
>>> As part of this patchset, the new API is developed and integrated into the
>>> devlink health and mlx5e TX reporter.
>>> Also, added some helpers together with the new API, which reduce the code
>>> required by the driver to fill dump and diagnose significantly.
>>>
>>> Eventually, it also deletes the old API.
>>>
>>> In addition, it includes some small fixes in the devlink and mlx5e TX reporter.
>>
>> Okay, just leaving, going to review this tomorrow. I would much rather
>> review the patchset from the beginning, not this incremental patchset.
>> It changes a lot of things, deprecating api what was just introduced.
>> Review nightmare :/
>>
>> Could we do revert, repost? For my health sakes :)
> 
> Eran are you ok with the revert?

Dave, thanks for your consideration.

During the review of this fixes series with Jiri yesterday, we reached 
to a conclusion that it would be cleaner to revert and re-post it again.
I thought I shall submit a revert patchset, but if just remove it, it 
would be better, I guess.

Jiri,
I will probably be able to provide a new version with fixed comments 
from here soon next week.

> 
> I'll do it once I have Eran's confirmation.

Note that you will also have to revert ARM compilation fix which was 
accepted on top.
https://patchwork.ozlabs.org/patch/1029047/

Thanks.