netdev - Re: [PATCH net-next 0/7] Devlink health updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190124.220846.372838862694196119.davem@davemloft.net>
Date:   Thu, 24 Jan 2019 22:08:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     eranbe@...lanox.com, netdev@...r.kernel.org, jiri@...lanox.com,
        saeedm@...lanox.com, moshe@...lanox.com
Subject: Re: [PATCH net-next 0/7] Devlink health updates

From: Jiri Pirko <jiri@...nulli.us>
Date: Tue, 22 Jan 2019 17:58:21 +0100

> Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@...lanox.com wrote:
>>This patchset fixes some comments that were received for the devlink
>>health series, mostly around the devlink health buffers API.
>>
>>It offers a new devlink<->driver API for passing health dump and diagnose info.
>>As part of this patchset, the new API is developed and integrated into the
>>devlink health and mlx5e TX reporter.
>>Also, added some helpers together with the new API, which reduce the code
>>required by the driver to fill dump and diagnose significantly.
>>
>>Eventually, it also deletes the old API.
>>
>>In addition, it includes some small fixes in the devlink and mlx5e TX reporter.
> 
> Okay, just leaving, going to review this tomorrow. I would much rather
> review the patchset from the beginning, not this incremental patchset.
> It changes a lot of things, deprecating api what was just introduced.
> Review nightmare :/
> 
> Could we do revert, repost? For my health sakes :)

Eran are you ok with the revert?

I'll do it once I have Eran's confirmation.