netdev - Re: [PATCH net-next] net: stmmac: Fix return value check in qcom_ethqos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190124.221347.1855347214634112498.davem@davemloft.net>
Date:   Thu, 24 Jan 2019 22:13:47 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     vkoul@...nel.org, niklas.cassel@...aro.org, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com,
        mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: Fix return value check in
 qcom_ethqos_probe()

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Wed, 23 Jan 2019 06:19:18 +0000

> In case of error, the function devm_clk_get() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().
> 
> Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied, thanks.