netdev - Re: [PATCH iproute2-master] bridge: fdb: Fix FDB dump with strict checking disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f1514e2-132b-f0f8-b3d5-dcb52dbc91bb@gmail.com>
Date:   Fri, 25 Jan 2019 10:12:21 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "ivecera@...hat.com" <ivecera@...hat.com>,
        "liali@...hat.com" <liali@...hat.com>, mlxsw <mlxsw@...lanox.com>
Subject: Re: [PATCH iproute2-master] bridge: fdb: Fix FDB dump with strict
 checking disabled

On 1/25/19 10:09 AM, Ido Schimmel wrote:
> While iproute2 correctly uses ifinfomsg struct as the ancillary header
> when requesting an FDB dump on old kernels, it sets the message type to
> RTM_GETLINK. This results in wrong reply being returned.
> 
> Fix this by using RTM_GETNEIGH instead.
> 
> Before:
> $ bridge fdb show brport dummy0
> Not RTM_NEWNEIGH: 00000158 00000010 00000002
> 
> After:
> $ bridge fdb show brport dummy0
> 2a:0b:41:1c:92:d3 vlan 1 master br0 permanent
> 2a:0b:41:1c:92:d3 master br0 permanent
> 33:33:00:00:00:01 self permanent
> 01:00:5e:00:00:01 self permanent
> 
> Fixes: 05880354c2cf ("bridge: fdb: Fix filtering with strict checking disabled")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: LiLiang <liali@...hat.com>
> ---
>  bridge/fdb.c         |  3 +--
>  include/libnetlink.h |  3 +++
>  lib/libnetlink.c     | 23 +++++++++++++++++++++++
>  3 files changed, 27 insertions(+), 2 deletions(-)
> 


Acked-by: David Ahern <dsahern@...il.com>