netdev - Re: [PATCH iproute2-next 05/19] rdma: Move resource PD logic to separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ad0319f-194c-d574-e7f7-eca71c7a008a@gmail.com>
Date:   Fri, 25 Jan 2019 10:19:22 -0700
From:   David Ahern <dsahern@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Leon Romanovsky <leonro@...lanox.com>,
        netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next 05/19] rdma: Move resource PD logic to
 separate file

On 1/22/19 11:31 AM, Leon Romanovsky wrote:
> +static const
> +struct filters pd_valid_filters[MAX_NUMBER_OF_FILTERS] = {
> +	{ .name = "dev", .is_number = false },
> +	{ .name = "users", .is_number = true },
> +	{ .name = "pid", .is_number = true },
> +	{ .name = "ctxn", .is_number = true },
> +	{ .name = "pdn", .is_number = true },
> +	{ .name = "ctxn", .is_number = true }
> +};

These should not be in a header file. Looks like you have done this in
other patches as well.