netdev - Re: [PATCH iproute2-next 05/19] rdma: Move resource PD logic to separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190127082957.GB3604@mtr-leonro.mtl.com>
Date:   Sun, 27 Jan 2019 10:29:57 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next 05/19] rdma: Move resource PD logic to
 separate file

On Fri, Jan 25, 2019 at 10:19:22AM -0700, David Ahern wrote:
> On 1/22/19 11:31 AM, Leon Romanovsky wrote:
> > +static const
> > +struct filters pd_valid_filters[MAX_NUMBER_OF_FILTERS] = {
> > +	{ .name = "dev", .is_number = false },
> > +	{ .name = "users", .is_number = true },
> > +	{ .name = "pid", .is_number = true },
> > +	{ .name = "ctxn", .is_number = true },
> > +	{ .name = "pdn", .is_number = true },
> > +	{ .name = "ctxn", .is_number = true }
> > +};
>
> These should not be in a header file. Looks like you have done this in
> other patches as well.

This is the outcome of how we build command line with single struct *rd,
see res_show(). While I refactored the code, I saw your comment is coming,
but decided to proceed anyway to make this series a little bit sane.

I'll definitely continue to refactor it, but for now, there is a need to see
valid_filters structure in RES_FUNC() macro.

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)