netdev - Re: [PATCH bpf-next v3 12/16] ppc: bpf: implement jitting of JMP32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f60ac679-efe0-df3b-2126-6507674078ef@linux.ibm.com>
Date:   Fri, 25 Jan 2019 11:52:16 +0530
From:   Sandipan Das <sandipan@...ux.ibm.com>
To:     Jiong Wang <jiong.wang@...ronome.com>
Cc:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com,
        "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>
Subject: Re: [PATCH bpf-next v3 12/16] ppc: bpf: implement jitting of JMP32

Hi Jiong,

On 25/01/19 5:40 AM, Jiong Wang wrote:
> This patch implements code-gen for new JMP32 instructions on ppc.
> 
> For JMP32 | JSET, instruction encoding for PPC_RLWINM_DOT is added to check
> the result of ANDing low 32-bit of operands.
> 
> Cc: Naveen N. Rao <naveen.n.rao@...ux.ibm.com>
> Cc: Sandipan Das <sandipan@...ux.ibm.com>
> Signed-off-by: Jiong Wang <jiong.wang@...ronome.com>
> ---
>  arch/powerpc/include/asm/ppc-opcode.h |   1 +
>  arch/powerpc/net/bpf_jit.h            |   4 ++
>  arch/powerpc/net/bpf_jit_comp64.c     | 120 ++++++++++++++++++++++++++++++----
>  3 files changed, 111 insertions(+), 14 deletions(-)
> 
> [...]

Looks good to me.

Reviewed-by: Sandipan Das <sandipan@...ux.ibm.com>


--
With Regards,
Sandipan