netdev - Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9632d46-91f7-49a9-3f32-76ada6317da9@mellanox.com>
Date:   Sun, 27 Jan 2019 06:37:49 +0000
From:   Eli Britstein <elibr@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     "pshelar@....org" <pshelar@....org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "blp@....org" <blp@....org>,
        "dev@...nvswitch.org" <dev@...nvswitch.org>,
        Roi Dayan <roid@...lanox.com>,
        "simon.horman@...ronome.com" <simon.horman@...ronome.com>
Subject: Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures
 using macros


On 1/27/2019 1:04 AM, David Miller wrote:
> From: Eli Britstein <elibr@...lanox.com>
> Date: Thu, 24 Jan 2019 11:46:47 +0200
>
>> Declare ovs key structures using macros to enable retrieving fields
>> information, with no functional change.
>>
>> Signed-off-by: Eli Britstein <elibr@...lanox.com>
>> Reviewed-by: Roi Dayan <roid@...lanox.com>
> I agree with Pravin, this need a much better commit message.
>
> Maybe even better to submit this alongside whatever is supposed
> to use these new macros.

This patch is equivalent to a work done in the OVS tree.

https://patchwork.ozlabs.org/patch/1023405/

As a standalone it doesn't serve any purpose (as mentioned - no 
functional change).

It serves as a pre-step towards another patch in the OVS:

https://patchwork.ozlabs.org/patch/1022794/

So, the purpose of doing it in the kernel is just to keep this H file 
identical. Once it is approved for the kernel, we will be able to 
proceed with it in the OVS.