netdev - [PATCH] : net : hso : do not call unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Jan 2019 16:28:38 +0000
From:   "Yavuz, Tuba" <tuba@....ufl.edu>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH] : net : hso : do not call unregister_netdev if not registered

On an error path inside the hso_create_net_device function of the hso 
driver, hso_free_net_device gets called. This causes potentially a 
negative reference count in the net device if register_netdev has not 
been called yet as hso_free_net_device calls unregister_netdev 
regardless. I think the driver should distinguish these cases and call 
unregister_netdev only if register_netdev has been called.

Reported-by: Tuba Yavuz <tuba@....ufl.edu>
Signed-off-by: Tuba Yavuz <tuba@....ufl.edu>
---

--- drivers/net/usb/hso.c.orig	2019-01-27 14:45:58.232683119 -0500
+++ drivers/net/usb/hso.c	2019-01-27 14:47:43.592683629 -0500
@@ -2377,7 +2377,7 @@ static void hso_free_net_device(struct h

 	remove_net_device(hso_net->parent);

-	if (hso_net->net)
+	if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED)
 		unregister_netdev(hso_net->net);

 	/* start freeing */