netdev - Re: [PATCH] : net : hso : do not call unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190130.135803.1455746285854639679.davem@davemloft.net>
Date:   Wed, 30 Jan 2019 13:58:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tuba@....ufl.edu
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] : net : hso : do not call unregister_netdev if not
 registered

From: "Yavuz, Tuba" <tuba@....ufl.edu>
Date: Mon, 28 Jan 2019 16:28:38 +0000

> On an error path inside the hso_create_net_device function of the hso 
> driver, hso_free_net_device gets called. This causes potentially a 
> negative reference count in the net device if register_netdev has not 
> been called yet as hso_free_net_device calls unregister_netdev 
> regardless. I think the driver should distinguish these cases and call 
> unregister_netdev only if register_netdev has been called.
> 
> Reported-by: Tuba Yavuz <tuba@....ufl.edu>
> Signed-off-by: Tuba Yavuz <tuba@....ufl.edu>

This does not apply cleanly to the net tree.

Also, please stop putting those spaces after the subsystem prefixes
in your Subject line.  Put the colon character immediately after
each subsystem prefix.

Thank you.