netdev - Re: [PATCH] : net : hso : do not call unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Jan 2019 23:50:44 +0000
From:   "Yavuz, Tuba" <tuba@....ufl.edu>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] : net : hso : do not call unregister_netdev if not
 registered

Hi David,

I'll fix the spaces in the subject.

When I checked my patch it only had a p0 patch warning but I am not sure how to fix it. 

WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

drivers/net/usb/hso.patch has style problems, please review.

So, please advise.

Best,

Tuba Yavuz, Ph.D.
Assistant Professor
Electrical and Computer Engineering Department
University of Florida
Gainesville, FL 32611
Webpage: http://www.tuba.ece.ufl.edu/
Email: tuba@....ufl.edu
Phone: (352) 846 0202

________________________________________
From: David Miller <davem@...emloft.net>
Sent: Wednesday, January 30, 2019 4:58 PM
To: Yavuz, Tuba
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] : net : hso : do not call unregister_netdev if not registered

From: "Yavuz, Tuba" <tuba@....ufl.edu>
Date: Mon, 28 Jan 2019 16:28:38 +0000

> On an error path inside the hso_create_net_device function of the hso
> driver, hso_free_net_device gets called. This causes potentially a
> negative reference count in the net device if register_netdev has not
> been called yet as hso_free_net_device calls unregister_netdev
> regardless. I think the driver should distinguish these cases and call
> unregister_netdev only if register_netdev has been called.
>
> Reported-by: Tuba Yavuz <tuba@....ufl.edu>
> Signed-off-by: Tuba Yavuz <tuba@....ufl.edu>

This does not apply cleanly to the net tree.

Also, please stop putting those spaces after the subsystem prefixes
in your Subject line.  Put the colon character immediately after
each subsystem prefix.

Thank you.