netdev - Re: [PATCH net] net: b44: replace dev_kfree_skb_xxx by dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190129.101159.136552412219353385.davem@davemloft.net>
Date:   Tue, 29 Jan 2019 10:11:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     albin_yang@....com
Cc:     netdev@...r.kernel.org, michael.chan@...adcom.com,
        yang.wei9@....com.cn
Subject: Re: [PATCH net] net: b44: replace dev_kfree_skb_xxx by
 dev_consume_skb_xxx for drop profiles

From: Yang Wei <albin_yang@....com>
Date: Tue, 29 Jan 2019 23:04:40 +0800

> From: Yang Wei <yang.wei9@....com.cn>
> 
> The skb should be freed by dev_consume_skb_any() in b44_start_xmit()
> when bounce_skb is used. The skb is be replaced by bounce_skb, so the
> original skb should be consumed(not drop).
> 
> dev_consume_skb_irq() should be called in b44_tx() when skb xmit 
> done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@....com.cn>

Applied.