netdev - Re: [PATCH net] net: b44: replace dev_kfree_skb_xxx by dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d0c1e44-ff54-b1e5-d057-6889adb1e51d@cogentembedded.com>
Date:   Wed, 30 Jan 2019 10:43:43 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Yang Wei <albin_yang@....com>, netdev@...r.kernel.org
Cc:     michael.chan@...adcom.com, davem@...emloft.net,
        yang.wei9@....com.cn
Subject: Re: [PATCH net] net: b44: replace dev_kfree_skb_xxx by
 dev_consume_skb_xxx for drop profiles

Hello!

On 29.01.2019 18:04, Yang Wei wrote:

> From: Yang Wei <yang.wei9@....com.cn>
> 
> The skb should be freed by dev_consume_skb_any() in b44_start_xmit()
> when bounce_skb is used. The skb is be replaced by bounce_skb, so the

    s/be/being/?

> original skb should be consumed(not drop).
> 
> dev_consume_skb_irq() should be called in b44_tx() when skb xmit
> done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@....com.cn>
[...]

MBR, Sergei