netdev - Re: [PATCH] ath10k: snoc: remove set but not used variable 'ar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ASDXMQto_dqPOuUEX9vqqbWmor8qvpwxBVTg6tSnHkfsCzpw@mail.gmail.com>
Date:   Tue, 29 Jan 2019 10:12:42 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Kalle Valo <kvalo@...eaurora.org>, ath10k@...ts.infradead.org,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ath10k: snoc: remove set but not used variable 'ar_snoc'

On Mon, Jan 28, 2019 at 9:53 PM YueHaibing <yuehaibing@...wei.com> wrote:
>
> ping...

For some reason, your patch shows up as Deferred in patchwork:

https://patchwork.kernel.org/patch/10589789/

So the maintainers have accidentally (?) ignored it. I'm not what the
official suggestion is for that, but you might just resend.

In any case...

> On 2018/9/6 10:29, YueHaibing wrote:
> > From: Yue Haibing <yuehaibing@...wei.com>
> >
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_tx_pipe_cleanup':
> > drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning:
> >  variable 'ar_snoc' set but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

...patch looks fine to me:

Reviewed-by: Brian Norris <briannorris@...omium.org>