netdev - Re: [PATCH] ath10k: snoc: remove set but not used variable 'ar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b16caf3-9a25-99d0-5b35-f27d6e5a5c65@huawei.com>
Date:   Tue, 29 Jan 2019 13:53:20 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Kalle Valo <kvalo@...eaurora.org>
CC:     <ath10k@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] ath10k: snoc: remove set but not used variable 'ar_snoc'

ping...

On 2018/9/6 10:29, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@...wei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_tx_pipe_cleanup':
> drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning:
>  variable 'ar_snoc' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  drivers/net/wireless/ath/ath10k/snoc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
> index fa1843a..2d6ae00 100644
> --- a/drivers/net/wireless/ath/ath10k/snoc.c
> +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> @@ -678,13 +678,11 @@ static void ath10k_snoc_tx_pipe_cleanup(struct ath10k_snoc_pipe *snoc_pipe)
>  {
>  	struct ath10k_ce_pipe *ce_pipe;
>  	struct ath10k_ce_ring *ce_ring;
> -	struct ath10k_snoc *ar_snoc;
>  	struct sk_buff *skb;
>  	struct ath10k *ar;
>  	int i;
>  
>  	ar = snoc_pipe->hif_ce_state;
> -	ar_snoc = ath10k_snoc_priv(ar);
>  	ce_pipe = snoc_pipe->ce_hdl;
>  	ce_ring = ce_pipe->src_ring;
> 
> 
> .
>