netdev - Re: [PATCH] rtlwifi: remove set but not used variable 'cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Jan 2019 14:03:24 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Ping-Ke Shih <pkshih@...ltek.com>,
        Kalle Valo <kvalo@...eaurora.org>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

+cc netdev@...r.kernel.org

On 2019/1/29 13:57, YueHaibing wrote:
> ping...
> 
> On 2018/9/11 20:12, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/realtek/rtlwifi/base.c: In function 'rtl_c2h_content_parsing':
>> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>>  variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/net/wireless/realtek/rtlwifi/base.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
>> index f4122c8..92b6918 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -2310,11 +2310,10 @@ static void rtl_c2h_content_parsing(struct ieee80211_hw *hw,
>>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>>  	struct rtl_hal_ops *hal_ops = rtlpriv->cfg->ops;
>>  	const struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
>> -	u8 cmd_id, cmd_seq, cmd_len;
>> +	u8 cmd_id, cmd_len;
>>  	u8 *cmd_buf = NULL;
>>  
>>  	cmd_id = GET_C2H_CMD_ID(skb->data);
>> -	cmd_seq = GET_C2H_SEQ(skb->data);
>>  	cmd_len = skb->len - C2H_DATA_OFFSET;
>>  	cmd_buf = GET_C2H_DATA_PTR(skb->data);
>>
>>
>> .
>>