netdev - Re: [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source mac changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Jan 2019 22:20:54 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "xiangxia.m.yue@...il.com" <xiangxia.m.yue@...il.com>,
        "gerlitz.or@...il.com" <gerlitz.or@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Hadar Hen Zion <hadarh@...lanox.com>
Subject: Re: [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source
 mac changed

On Mon, 2019-01-28 at 15:28 -0800, xiangxia.m.yue@...il.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> When we offload tc filters to hardware, hardware flows can
> be updated when mac of encap destination ip is changed.
> But we ignore one case, that the mac of local encap ip can
> be changed too, so we should also update them.
> 
> To fix it, add route_dev in mlx5e_encap_entry struct to save
> the local encap netdevice, and when mac changed, kernel will
> flush all the neighbour on the netdevice and send
> NETEVENT_NEIGH_UPDATE
> event. The mlx5 driver will delete the flows and add them when
> neighbour
> available again.
> 
> Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update
> flow")
> Cc: Hadar Hen Zion <hadarh@...lanox.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> Reviewed-by: Or Gerlitz <ogerlitz@...lanox.com>
> 
> 

Thank you Tonghao and Or.

Acked-by: Saeed Mahameed <saeedm@...lanox.com>