netdev - Re: [PATCH net v5 2/2] net/mlx5e: Don't overwrite pedit action when multiple pedit used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Jan 2019 22:21:26 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "xiangxia.m.yue@...il.com" <xiangxia.m.yue@...il.com>,
        "gerlitz.or@...il.com" <gerlitz.or@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH net v5 2/2] net/mlx5e: Don't overwrite pedit action when
 multiple pedit used

On Mon, 2019-01-28 at 15:28 -0800, xiangxia.m.yue@...il.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> In some case, we may use multiple pedit actions to modify packets.
> The command shown as below: the last pedit action is effective.
> 
> $ tc filter add dev netdev_rep parent ffff: protocol ip prio 1    \
> 	flower skip_sw ip_proto icmp dst_ip 3.3.3.3        \
> 	action pedit ex munge ip dst set 192.168.1.100 pipe    \
> 	action pedit ex munge eth src set 00:00:00:00:00:01 pipe    \
> 	action pedit ex munge eth dst set 00:00:00:00:00:02 pipe    \
> 	action csum ip pipe    \
> 	action tunnel_key set src_ip 1.1.1.100 dst_ip 1.1.1.200
> dst_port 4789 id 100 \
> 	action mirred egress redirect dev vxlan0
> 
> To fix it, we add max_mod_hdr_actions to mlx5e_tc_flow_parse_attr
> struction,
> max_mod_hdr_actions will store the max pedit action number we support
> and
> num_mod_hdr_actions indicates how many pedit action we used, and
> store all
> pedit action to mod_hdr_actions.
> 
> Fixes: d79b6df6b10a ("net/mlx5e: Add parsing of TC pedit actions to
> HW format")
> Cc: Or Gerlitz <ogerlitz@...lanox.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> Reviewed-by: Or Gerlitz <ogerlitz@...lanox.com>
> ---
> v3: Remove the unnecessary init.
> v2: Fix comment message and change tag from net-next to net.
> ---


Thank you Tonghao and Or.

Acked-by: Saeed Mahameed <saeedm@...lanox.com>